Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brightcom Bid adapter: add support for uspConsent, coppa, schain, userIdAsEids, userId #9063

Merged
merged 2 commits into from
Oct 18, 2022

Conversation

prBigBrother
Copy link
Contributor

Type of change

  • Feature

Description of change

Add support for uspConsent, coppa, schain, userIdAsEids, userId

Contact

alexandruc@brightcom.com

@ChrisHuie
Copy link
Collaborator

ChrisHuie commented Oct 3, 2022

@prBigBrother can you please add unit test coverage for this pr? Also, make sure docs are updated with these changes if you haven't 🙏

@ChrisHuie ChrisHuie self-requested a review October 3, 2022 11:54
@ChrisHuie ChrisHuie self-assigned this Oct 3, 2022
@prBigBrother
Copy link
Contributor Author

@ChrisHuie thanks for noticing about tests!

tests are added

@prBigBrother
Copy link
Contributor Author

Hi @ChrisHuie! sorry to bother you, would it be possible to receive an update on the pul request's current status?

@alexs-bc
Copy link

@ChrisHuie can you please advice on this pipeline error (Could not find a usable config.yml, you may have revoked the CircleCI OAuth app)?

@ChrisHuie
Copy link
Collaborator

ChrisHuie commented Oct 13, 2022

@alexs-bc @prBigBrother haven't been able to fix the circleci issue. I will manually run this through our integration tests today to verify. Can you guys document these updates to your adapter in our docs repo please, then this should be good to go -> https://github.com/prebid/prebid.github.io

@ChrisHuie ChrisHuie merged commit f113129 into prebid:master Oct 18, 2022
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
…rIdAsEids, userId (prebid#9063)

* Brightcom: add support for uspConsent, coppa, schain, userIdAsEids, userId

* Brightcom: tests for updates
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
…rIdAsEids, userId (prebid#9063)

* Brightcom: add support for uspConsent, coppa, schain, userIdAsEids, userId

* Brightcom: tests for updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants